netdev - Re: [PATCH net] bonding: fix curr_active_slave/carrier with loadbalance arp monitoring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141119.151023.684141809270754348.davem@davemloft.net>
Date:	Wed, 19 Nov 2014 15:10:23 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	gospo@...ulusnetworks.com
Cc:	vfalico@...il.com, nikolay@...hat.com, netdev@...r.kernel.org,
	j.vosburgh@...il.com, andy@...yhouse.net, dingtianhong@...wei.com
Subject: Re: [PATCH net] bonding: fix curr_active_slave/carrier with
 loadbalance arp monitoring

From: Andy Gospodarek <gospo@...ulusnetworks.com>
Date: Tue, 18 Nov 2014 10:28:47 -0500

> On Tue, Nov 18, 2014 at 03:37:27PM +0100, Veaceslav Falico wrote:
>> On Tue, Nov 18, 2014 at 03:14:44PM +0100, Nikolay Aleksandrov wrote:
>> >Since commit 6fde8f037e60 ("bonding: fix locking in
>> >bond_loadbalance_arp_mon()") we can have a stale bond carrier state and
>> >stale curr_active_slave when using arp monitoring in loadbalance modes. The
>> >reason is that in bond_loadbalance_arp_mon() we can't have
>> >do_failover == true but slave_state_changed == false, whenever do_failover
>> >is true then slave_state_changed is also true. Then the following piece
>> >from bond_loadbalance_arp_mon():
>> >               if (slave_state_changed) {
>> >                       bond_slave_state_change(bond);
>> >                       if (BOND_MODE(bond) == BOND_MODE_XOR)
>> >                               bond_update_slave_arr(bond, NULL);
>> >               } else if (do_failover) {
>> 
>> Ouch, must have been a big PITA to track :).
> 
> Agreed!
 ...
>> Acked-by: Veaceslav Falico <vfalico@...il.com>
> 
> Acked-by: Andy Gospodarek <gospo@...ulusnetworks.com>

Applied, and queued up for -stable, thanks everyone!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html