netdev - Re: [PATCH net] net/mlx4_en: Add VXLAN ndo calls to the PF net device ops too

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20141119.151155.2119587385505880097.davem@davemloft.net>
Date:	Wed, 19 Nov 2014 15:11:55 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ogerlitz@...lanox.com
Cc:	netdev@...r.kernel.org, fw@...len.de, amirv@...lanox.com,
	saeedm@...lanox.com
Subject: Re: [PATCH net] net/mlx4_en: Add VXLAN ndo calls to the PF net
 device ops too

From: Or Gerlitz <ogerlitz@...lanox.com>
Date: Tue, 18 Nov 2014 17:51:27 +0200

> This is currently missing, which results in a crash when one attempts
> to set VXLAN tunnel over the mlx4_en when acting as PF.
> 
> 	[ 2408.785472] BUG: unable to handle kernel NULL pointer dereference at (null)
> 	[...]
> 	[ 2408.994104] Call Trace:
> 	[ 2408.996584]  [<ffffffffa021f7f5>] ? vxlan_get_rx_port+0xd6/0x103 [vxlan]
> 	[ 2409.003316]  [<ffffffffa021f71f>] ? vxlan_lowerdev_event+0xf2/0xf2 [vxlan]
> 	[ 2409.010225]  [<ffffffffa0630358>] mlx4_en_start_port+0x862/0x96a [mlx4_en]
> 	[ 2409.017132]  [<ffffffffa063070f>] mlx4_en_open+0x17f/0x1b8 [mlx4_en]
> 
> While here, make sure to invoke vxlan_get_rx_port() only when VXLAN
> offloads are actually enabled and not when they are only supported.
> 
> Reported-by: Ido Shamay <idos@...lanox.com>
> Signed-off-by: Or Gerlitz <ogerlitz@...lanox.com>

Applied, -stable material?  If so for what releases?

In the future, if you add an appropriated Fixes: tag I can figure most
of this out without asking you.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html