lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 23 Nov 2014 12:13:54 +0200 From: Eyal perry <eyalpe@....mellanox.co.il> To: David Miller <davem@...emloft.net>, amirv@...lanox.com CC: netdev@...r.kernel.org, ben@...adent.org.uk, ogerlitz@...lanox.com, yevgenyp@...lanox.com, eyalpe@...lanox.com, thomas.lendacky@....com, ariel.elior@...gic.com, prashant@...adcom.com, mchan@...adcom.com, hariprasad@...lsio.com, sathya.perla@...lex.com, subbu.seetharaman@...lex.com, ajit.khaparde@...lex.com, jeffrey.t.kirsher@...el.com, jesse.brandeburg@...el.com, bruce.w.allan@...el.com, carolyn.wyborny@...el.com, donald.c.skidmore@...el.com, gregory.v.rose@...el.com, matthew.vick@...el.com, john.ronciak@...el.com, mitch.a.williams@...el.com, linux-net-drivers@...arflare.com, sshah@...arflare.com, sbhatewara@...are.com, pv-drivers@...are.com Subject: Re: [PATCH net-next V1 1/2] ethtool: Support for configurable RSS hash function On 11/22/2014 11:54 PM, David Miller wrote: > From: Amir Vadai <amirv@...lanox.com> > Date: Thu, 20 Nov 2014 16:26:49 +0200 > >> + /* We require at least one supported parameter to be changed and no >> + * change in any of the unsupported parameters >> + */ >> + if ((!indir && !key) || hfunc != ETH_RSS_HASH_NO_CHANGE) >> + return -EOPNOTSUPP; >> + > > I know it will make more work for you, but all of these driver > implementations of this hook should: > > 1) Accept hfunc of whatever hash function the chip is using, > not just ETH_RSS_HASH_NO_CHANGE. > > 2) Provide an accurate hfunc value in the ->get() call. Ok, I'll do it for V2. > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists