netdev - Re: [PATCH net-next V1 1/2] ethtool: Support for configurable RSS hash function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20141122.165407.641057904952001007.davem@davemloft.net>
Date:	Sat, 22 Nov 2014 16:54:07 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	amirv@...lanox.com
Cc:	netdev@...r.kernel.org, ben@...adent.org.uk, ogerlitz@...lanox.com,
	yevgenyp@...lanox.com, eyalpe@...lanox.com,
	thomas.lendacky@....com, ariel.elior@...gic.com,
	prashant@...adcom.com, mchan@...adcom.com, hariprasad@...lsio.com,
	sathya.perla@...lex.com, subbu.seetharaman@...lex.com,
	ajit.khaparde@...lex.com, jeffrey.t.kirsher@...el.com,
	jesse.brandeburg@...el.com, bruce.w.allan@...el.com,
	carolyn.wyborny@...el.com, donald.c.skidmore@...el.com,
	gregory.v.rose@...el.com, matthew.vick@...el.com,
	john.ronciak@...el.com, mitch.a.williams@...el.com,
	linux-net-drivers@...arflare.com, sshah@...arflare.com,
	sbhatewara@...are.com, pv-drivers@...are.com
Subject: Re: [PATCH net-next V1 1/2] ethtool: Support for configurable RSS
 hash function

From: Amir Vadai <amirv@...lanox.com>
Date: Thu, 20 Nov 2014 16:26:49 +0200

> +	/* We require at least one supported parameter to be changed and no
> +	 * change in any of the unsupported parameters
> +	 */
> +	if ((!indir && !key) || hfunc != ETH_RSS_HASH_NO_CHANGE)
> +		return -EOPNOTSUPP;
> +

I know it will make more work for you, but all of these driver
implementations of this hook should:

1) Accept hfunc of whatever hash function the chip is using,
   not just ETH_RSS_HASH_NO_CHANGE.

2) Provide an accurate hfunc value in the ->get() call.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html