netdev - Re: [PATCH net-next 12/14] mlx4: use netdev_rss_key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1416692961.7215.31.camel@decadent.org.uk>
Date:	Sat, 22 Nov 2014 21:49:21 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Eric Dumazet <edumazet@...gle.com>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	Thomas Lendacky <Thomas.Lendacky@....com>,
	Ariel Elior <ariel.elior@...gic.com>,
	Michael Chan <mchan@...adcom.com>,
	Prashant Sreedharan <prashant@...adcom.com>,
	Rasesh Mody <rasesh.mody@...gic.com>,
	Sathya Perla <sathya.perla@...lex.com>,
	Subbu Seetharaman <subbu.seetharaman@...lex.com>,
	Ajit Khaparde <ajit.khaparde@...lex.com>,
	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	Amir Vadai <amirv@...lanox.com>,
	Shradha Shah <sshah@...arflare.com>,
	Shreyas Bhatewara <sbhatewara@...are.com>
Subject: Re: [PATCH net-next 12/14] mlx4: use netdev_rss_key_fill() helper

On Sun, 2014-11-16 at 06:23 -0800, Eric Dumazet wrote:
> Use of well known RSS key increases attack surface.
> Switch to a random one, using generic helper so that all
> ports share a common key.
> 
> Also provide ethtool -x support to fetch RSS key
[...]
> @@ -1799,6 +1805,7 @@ const struct ethtool_ops mlx4_en_ethtool_ops = {
>  	.get_rxnfc = mlx4_en_get_rxnfc,
>  	.set_rxnfc = mlx4_en_set_rxnfc,
>  	.get_rxfh_indir_size = mlx4_en_get_rxfh_indir_size,
> +	.get_rxfh_key_size = mlx4_en_get_rxfh_key_size,
>  	.get_rxfh = mlx4_en_get_rxfh,
>  	.set_rxfh = mlx4_en_set_rxfh,
[...]

A driver that implements get_rxfh_key_size() and set_rxfh() is assumed
to support setting the RSS key (and only the key).  However,
mlx4_en_set_rxfh() will currently crash if a new indirection table is
not provided.

Ben.

-- 
Ben Hutchings
Logic doesn't apply to the real world. - Marvin Minsky

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)