netdev - Re: [PATCH v2] Add support of Cavium Liquidio ethernet adapters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54739C92.5070309@gmail.com>
Date:	Mon, 24 Nov 2014 13:01:06 -0800
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Raghu Vatsavayi <rvatsavayi@...iumnetworks.com>,
	davem@...emloft.net
CC:	netdev@...r.kernel.org,
	Derek Chickles <derek.chickles@...iumnetworks.com>,
	Satanand Burla <satananda.burla@...iumnetworks.com>,
	Felix Manlunas <felix.manlunas@...iumnetworks.com>,
	Raghu Vatsavayi <raghu.vatsavayi@...iumnetworks.com>
Subject: Re: [PATCH v2] Add support of Cavium Liquidio ethernet adapters

On 11/23/2014 07:19 PM, Raghu Vatsavayi wrote:
> +if LIQUIDIO
> +
> +config LIQUIDIO_NAPI
> +	bool "Enable NAPI for LiquidIO"
> +	default y
> +	---help---
> +	  NAPI is a new driver API designed to reduce CPU and interrupt load
> +	  when the driver is receiving lots of packets from the card. You
> +	  would only disable this feature in very specific instances, like
> +	  an application that very rapidly sets up and tears down connections.
> +
> +	  If in doubt, say Y.

You probably do not want to offer a non-NAPI variant, pretty much all
drivers have NAPI built-in now.

> +
> +config LIQUIDIO_DEBUG
> +	int "Debug level for LiquidIO"
> +	range 0 4
> +	default 0
> +	---help---
> +	  Enables more extensive debug output. This may negatively
> +	  affect performance, so use values > 0 with caution.
> +	  0 disables extra debug
> +	  1 enables general messages
> +	  2 enables register access messages
> +	  3 enables debug messages
> +	  4 enables flow messages
> +
> +	  If in doubt, say 0.

This should be moved to dynamic_debug/ethtools' msglvl control knob.
--
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html