netdev - Re: [PATCH v2] Add support of Cavium Liquidio ethernet adapters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 24 Nov 2014 16:08:37 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	f.fainelli@...il.com
Cc:	rvatsavayi@...iumnetworks.com, netdev@...r.kernel.org,
	derek.chickles@...iumnetworks.com,
	satananda.burla@...iumnetworks.com,
	felix.manlunas@...iumnetworks.com,
	raghu.vatsavayi@...iumnetworks.com
Subject: Re: [PATCH v2] Add support of Cavium Liquidio ethernet adapters

From: Florian Fainelli <f.fainelli@...il.com>
Date: Mon, 24 Nov 2014 13:01:06 -0800

> On 11/23/2014 07:19 PM, Raghu Vatsavayi wrote:
>> +if LIQUIDIO
>> +
>> +config LIQUIDIO_NAPI
>> +	bool "Enable NAPI for LiquidIO"
>> +	default y
>> +	---help---
>> +	  NAPI is a new driver API designed to reduce CPU and interrupt load
>> +	  when the driver is receiving lots of packets from the card. You
>> +	  would only disable this feature in very specific instances, like
>> +	  an application that very rapidly sets up and tears down connections.
>> +
>> +	  If in doubt, say Y.
> 
> You probably do not want to offer a non-NAPI variant, pretty much all
> drivers have NAPI built-in now.

+1.

>> +config LIQUIDIO_DEBUG
>> +	int "Debug level for LiquidIO"
>> +	range 0 4
>> +	default 0
> 
> This should be moved to dynamic_debug/ethtools' msglvl control knob.

+1
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html