netdev - RE: [PATCH v2] Add support of Cavium Liquidio ethernet adapters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 1 Dec 2014 19:57:20 +0000
From:	"Vatsavayi, Raghu" <Raghu.Vatsavayi@...iumnetworks.com>
To:	David Miller <davem@...emloft.net>,
	"f.fainelli@...il.com" <f.fainelli@...il.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Chickles, Derek" <Derek.Chickles@...iumnetworks.com>,
	"Burla, Satananda" <Satananda.Burla@...iumnetworks.com>,
	"Manlunas, Felix" <Felix.Manlunas@...iumnetworks.com>
Subject: RE: [PATCH v2] Add support of Cavium Liquidio ethernet adapters


> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net]
> Sent: Monday, November 24, 2014 1:09 PM
> To: f.fainelli@...il.com
> Cc: Vatsavayi, Raghu; netdev@...r.kernel.org; Chickles, Derek; Burla,
> Satananda; Manlunas, Felix; Vatsavayi, Raghu
> Subject: Re: [PATCH v2] Add support of Cavium Liquidio ethernet adapters
> 
> From: Florian Fainelli <f.fainelli@...il.com>
> Date: Mon, 24 Nov 2014 13:01:06 -0800
> 
> > On 11/23/2014 07:19 PM, Raghu Vatsavayi wrote:
> >> +if LIQUIDIO
> >> +
> >> +config LIQUIDIO_NAPI
> >> +	bool "Enable NAPI for LiquidIO"
> >> +	default y
> >> +	---help---
> >> +	  NAPI is a new driver API designed to reduce CPU and interrupt load
> >> +	  when the driver is receiving lots of packets from the card. You
> >> +	  would only disable this feature in very specific instances, like
> >> +	  an application that very rapidly sets up and tears down connections.
> >> +
> >> +	  If in doubt, say Y.
> >
> > You probably do not want to offer a non-NAPI variant, pretty much all
> > drivers have NAPI built-in now.
> 
> +1.
> 
> >> +config LIQUIDIO_DEBUG
> >> +	int "Debug level for LiquidIO"
> >> +	range 0 4
> >> +	default 0
> >
> > This should be moved to dynamic_debug/ethtools' msglvl control knob.
> 
> +1

Thanks for the comments. We are in the process of removing Kconfig based non-NAPI
selection and enabling NAPI by default. We are also removing  separate debug section
and integrating it with ethtool based msglvl debug infrastructure. Additionally we are
planning to clean up non-kerneldoc style comments.

Regards
Raghu
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html