netdev - Re: [PATCH 0/5 net] bridge: Fix missing Netlink message validations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <547606B3.3060808@gmail.com>
Date:	Wed, 26 Nov 2014 08:58:27 -0800
From:	John Fastabend <john.fastabend@...il.com>
To:	Thomas Graf <tgraf@...g.ch>, Jiri Pirko <jiri@...nulli.us>
CC:	davem@...emloft.net, stephen@...workplumber.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH 0/5 net] bridge: Fix missing Netlink message validations

On 11/26/2014 04:42 AM, Thomas Graf wrote:
> Adds various missing length checks in the bridging code for Netlink
> messages and corresponding attributes provided by user space.
>
> Thomas Graf (5):
>    bridge: Validate IFLA_BRIDGE_FLAGS attribute length
>    net: Validate IFLA_BRIDGE_MODE attribute length
>    net: Check for presence of IFLA_AF_SPEC
>    bridge: Add missing policy entry for IFLA_BRPORT_FAST_LEAVE
>    bridge: Sanitize IFLA_EXT_MASK for AF_BRIDGE:RTM_GETLINK
>
>   drivers/net/ethernet/emulex/benet/be_main.c   |  5 +++++
>   drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |  5 +++++
>   net/bridge/br_netlink.c                       |  1 +
>   net/core/rtnetlink.c                          | 23 ++++++++++++++++++-----
>   4 files changed, 29 insertions(+), 5 deletions(-)
>

+Jiri

Looks like a miss in bond_netlink also? Seems like writing
a smatch or cocci check for this would be worthwhile.

>
> diff --git a/drivers/net/bonding/bond_netlink.c b/drivers/net/bonding/bond_netlink.c
> index 3e6eebd..7b11243 100644
> --- a/drivers/net/bonding/bond_netlink.c
> +++ b/drivers/net/bonding/bond_netlink.c
> @@ -225,7 +225,12 @@ static int bond_changelink(struct net_device *bond_dev,
>
>                 bond_option_arp_ip_targets_clear(bond);
>                 nla_for_each_nested(attr, data[IFLA_BOND_ARP_IP_TARGET], rem) {
> -                       __be32 target = nla_get_be32(attr);
> +                       __be32 target;
> +
> +                       if (nla_len(attr) < sizeof(target))
> +                               return -EINVAL;
> +
> +                       target = nla_get_be32(attr);
>
>                         bond_opt_initval(&newval, (__force u64)target);
>                         err = __bond_opt_set(bond, BOND_OPT_ARP_TARGETS,

-- 
John Fastabend         Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html