netdev - Re: [PATCH 0/5 net] bridge: Fix missing Netlink message validations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141126170610.GA2399@casper.infradead.org>
Date:	Wed, 26 Nov 2014 17:06:10 +0000
From:	Thomas Graf <tgraf@...g.ch>
To:	John Fastabend <john.fastabend@...il.com>
Cc:	Jiri Pirko <jiri@...nulli.us>, davem@...emloft.net,
	stephen@...workplumber.org, netdev@...r.kernel.org
Subject: Re: [PATCH 0/5 net] bridge: Fix missing Netlink message validations

On 11/26/14 at 08:58am, John Fastabend wrote:
> On 11/26/2014 04:42 AM, Thomas Graf wrote:
> >Adds various missing length checks in the bridging code for Netlink
> >messages and corresponding attributes provided by user space.
> >
> >Thomas Graf (5):
> >   bridge: Validate IFLA_BRIDGE_FLAGS attribute length
> >   net: Validate IFLA_BRIDGE_MODE attribute length
> >   net: Check for presence of IFLA_AF_SPEC
> >   bridge: Add missing policy entry for IFLA_BRPORT_FAST_LEAVE
> >   bridge: Sanitize IFLA_EXT_MASK for AF_BRIDGE:RTM_GETLINK
> >
> >  drivers/net/ethernet/emulex/benet/be_main.c   |  5 +++++
> >  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |  5 +++++
> >  net/bridge/br_netlink.c                       |  1 +
> >  net/core/rtnetlink.c                          | 23 ++++++++++++++++++-----
> >  4 files changed, 29 insertions(+), 5 deletions(-)
> >
> 
> +Jiri
> 
> Looks like a miss in bond_netlink also? Seems like writing
> a smatch or cocci check for this would be worthwhile.

Thanks, I'll take a look.

The cocci check is somewhat difficult as validation is often
centralized and decoupled from actual access to implement atomic
operations. I'll give it a try though.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html