| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAMw6YJJe_u1nL85J8mHR_71E_WY_aHJEC2fs9mynj4NuyQd1Sg@mail.gmail.com>
Date: Wed, 3 Dec 2014 00:01:37 +0200
From: Vadim Kochan <vadim4j@...il.com>
To: "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc: Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH iproute2] ip link: Show devices by link type
Hi,
The few things which were confused me a little:
#1 I think, I was not correct by calling it 'link type' in
descriptions, because it is rather the interface/device type than
link type ... so I can resend updated subject + man page in v2.
#2 Another think is that may be it would be better to consider the
ll_type_n2a too by the same 'ip link show type' or it is better to add
another option like 'ip link show link ether' and use ll_type_n2a to
filter devices by link type.
On Sun, Nov 30, 2014 at 7:58 PM, Vadim Kochan <vadim4j@...il.com> wrote:
> Added new option 'type' to 'ip link show'
> command which allows to filter devices by
> link type name:
>
> ip link show type bridge
> ip link show type vlan
>
> Signed-off-by: Vadim Kochan <vadim4j@...il.com>
> ---
> ip/ipaddress.c | 24 ++++++++++++++++++++++++
> ip/iplink.c | 2 +-
> man/man8/ip-link.8.in | 20 +++++++++++++++++++-
> 3 files changed, 44 insertions(+), 2 deletions(-)
>
> diff --git a/ip/ipaddress.c b/ip/ipaddress.c
> index 4d99324..a2f7a83 100644
> --- a/ip/ipaddress.c
> +++ b/ip/ipaddress.c
> @@ -57,6 +57,7 @@ static struct
> int flushe;
> int group;
> int master;
> + char *link_kind;
> } filter;
>
> static int do_link;
> @@ -189,6 +190,18 @@ static void print_linkmode(FILE *f, struct rtattr *tb)
> fprintf(f, "mode %s ", link_modes[mode]);
> }
>
> +static char *parse_link_kind(struct rtattr *tb)
> +{
> + struct rtattr *linkinfo[IFLA_INFO_MAX+1];
> +
> + parse_rtattr_nested(linkinfo, IFLA_INFO_MAX, tb);
> +
> + if (linkinfo[IFLA_INFO_KIND])
> + return RTA_DATA(linkinfo[IFLA_INFO_KIND]);
> +
> + return "";
> +}
> +
> static void print_linktype(FILE *fp, struct rtattr *tb)
> {
> struct rtattr *linkinfo[IFLA_INFO_MAX+1];
> @@ -551,6 +564,14 @@ int print_linkinfo(const struct sockaddr_nl *who,
> else if (filter.master > 0)
> return -1;
>
> + if (filter.link_kind && tb[IFLA_LINKINFO]) {
> + char *link_kind = parse_link_kind(tb[IFLA_LINKINFO]);
> + if (strcmp(link_kind, filter.link_kind)) {
> + return -1;
> + }
> + } else if (filter.link_kind)
> + return -1;
> +
> if (n->nlmsg_type == RTM_DELLINK)
> fprintf(fp, "Deleted ");
>
> @@ -1293,6 +1314,9 @@ static int ipaddr_list_flush_or_save(int argc, char **argv, int action)
> if (!ifindex)
> invarg("Device does not exist\n", *argv);
> filter.master = ifindex;
> + } else if (do_link && strcmp(*argv, "type") == 0) {
> + NEXT_ARG();
> + filter.link_kind = *argv;
> } else {
> if (strcmp(*argv, "dev") == 0) {
> NEXT_ARG();
> diff --git a/ip/iplink.c b/ip/iplink.c
> index ce6eb3e..f9a75d5 100644
> --- a/ip/iplink.c
> +++ b/ip/iplink.c
> @@ -82,7 +82,7 @@ void iplink_usage(void)
> fprintf(stderr, " [ master DEVICE ]\n");
> fprintf(stderr, " [ nomaster ]\n");
> fprintf(stderr, " [ addrgenmode { eui64 | none } ]\n");
> - fprintf(stderr, " ip link show [ DEVICE | group GROUP ] [up] [master DEV]\n");
> + fprintf(stderr, " ip link show [ DEVICE | group GROUP ] [up] [master DEV] [type TYPE]\n");
>
> if (iplink_have_newlink()) {
> fprintf(stderr, " ip link help [ TYPE ]\n");
> diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in
> index 9d4e3da..4233291 100644
> --- a/man/man8/ip-link.8.in
> +++ b/man/man8/ip-link.8.in
> @@ -148,7 +148,9 @@ ip-link \- network device configuration
> .IR GROUP " | "
> .BR up " | "
> .B master
> -.IR DEVICE " ]"
> +.IR DEVICE " | "
> +.B type
> +.IR TYPE " ]"
>
> .ti -8
> .B ip link help
> @@ -688,6 +690,12 @@ only display running interfaces.
> .I DEVICE
> specifies the master device which enslaves devices to show.
>
> +.TP
> +.BI type " TYPE "
> +.I TYPE
> +specifies the link type of devices to show.
> +
> +.TP
> The show command has additional formatting options:
>
> .TP
> @@ -719,6 +727,16 @@ ip link show
> Shows the state of all network interfaces on the system.
> .RE
> .PP
> +ip link show type bridge
> +.RS 4
> +Shows the bridge devices.
> +.RE
> +.PP
> +ip link show type vlan
> +.RS 4
> +Shows the vlan devices.
> +.RE
> +.PP
> ip link set dev ppp0 mtu 1400
> .RS 4
> Change the MTU the ppp0 device.
> --
> 2.1.3
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists