netdev - Re: [PATCH net-next v2 0/4] net: allow setting congctl via routing table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20141209.155844.1175199719902606020.davem@davemloft.net>
Date:	Tue, 09 Dec 2014 15:58:44 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	dborkman@...hat.com
Cc:	hannes@...essinduktion.org, fw@...len.de, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 0/4] net: allow setting congctl via routing
 table

From: Daniel Borkmann <dborkman@...hat.com>
Date: Sun,  7 Dec 2014 00:39:19 +0100

> This is the second part of our work and allows for setting the congestion
> control algorithm via routing table. For details, please see individual
> patches.
> 
> Joint work with Florian Westphal, suggested by Hannes Frederic Sowa.
> 
> Patch for iproute2: http://patchwork.ozlabs.org/patch/418149/
> 
> Thanks!
> 
> v1->v2:
>  - Very sorry, I noticed I had decnet disabled during testing.
>    Added missing header include in decnet, rest as is.

I don't like how you have to explicitly load the congestion control
module before asking for it to be used in the route entry metric.

It should request the module automatically just like the stack already
does for other cases.

You have run into this problem as a result of your design decision to
use that 32-bit key.  Therefore, I think you seriously need to
reconsider that aspect of your change.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html