netdev - Re: [PATCH net-next] macvlan: allow setting LRO independently of lower device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141209.160048.1159420484833054299.davem@davemloft.net>
Date:	Tue, 09 Dec 2014 16:00:48 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	mkubecek@...e.cz
Cc:	kaber@...sh.net, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] macvlan: allow setting LRO independently of
 lower device

From: Michal Kubecek <mkubecek@...e.cz>
Date: Fri, 5 Dec 2014 17:05:49 +0100

> Since commit fbe168ba91f7 ("net: generic dev_disable_lro() stacked
> device handling"), dev_disable_lro() zeroes NETIF_F_LRO feature flag
> first for a macvlan device and then for its lower device. As an attempt
> to set NETIF_F_LRO to zero is ignored, dev_disable_lro() issues a
> warning and taints kernel.
> 
> Allowing NETIF_F_LRO to be set independently of the lower device
> consists of three parts:
> 
>   - add the flag to hw_features to allow toggling it
>   - allow setting it to 0 even if lower device has the flag set
>   - add the flag to MACVLAN_FEATURES to restore copying from lower
>     device on macvlan creation
> 
> Signed-off-by: Michal Kubecek <mkubecek@...e.cz>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html