netdev - Re: is the commit 571dcfde2371 (net-next) a proper fix?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20141208.193532.411317230886917624.davem@davemloft.net>
Date:	Mon, 08 Dec 2014 19:35:32 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	andriy.shevchenko@...ux.intel.com
Cc:	chenhc@...ote.com, peppe.cavallaro@...com, netdev@...r.kernel.org
Subject: Re: is the commit 571dcfde2371 (net-next) a proper fix?

From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Date: Mon, 08 Dec 2014 12:23:20 +0200

> It seems for me that commit 571dcfde2371 (stmmac: platform: fix default
> values of the filter bins setting) is redundant (moreover, it could be a
> cause of crash in some cases when there is no platform data defined in
> case of CONFIG_OF).
> 
> In case of no OF the platform data should be provided by platform code
> where the defaults are set. What did I miss?

You missed follow-up fix:

commit 28603d13997e2ef47f18589cc9a44553aad49c86
Author: Huacai Chen <chenhc@...ote.com>
Date:   Thu Nov 27 21:05:34 2014 +0800

    stmmac: platform: Move plat_dat checking earlier
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html