netdev - Re: [net-next PATCH 3/6] ethernet/intel: Use napi_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1418334189.2410.113.camel@jtkirshe-mobl>
Date:	Thu, 11 Dec 2014 13:43:09 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Alexander Duyck <alexander.h.duyck@...hat.com>
Cc:	netdev@...r.kernel.org, brouer@...hat.com, ast@...mgrid.com,
	eric.dumazet@...il.com, davem@...emloft.net
Subject: Re: [net-next PATCH 3/6] ethernet/intel: Use napi_alloc_skb

On Tue, 2014-12-09 at 19:40 -0800, Alexander Duyck wrote:
> This change replaces calls to netdev_alloc_skb_ip_align with
> napi_alloc_skb.  The advantage of napi_alloc_skb is currently the fact
> that
> the page allocation doesn't make use of any irq disable calls.
> 
> There are few spots where I couldn't replace the calls as the buffer
> allocation routine is called as a part of init which is outside of the
> softirq context.
> 
> Cc: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@...hat.com>

Acked-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

> ---
>  drivers/net/ethernet/intel/e1000/e1000_main.c |    2 +-
>  drivers/net/ethernet/intel/e1000e/netdev.c    |    2 +-
>  drivers/net/ethernet/intel/fm10k/fm10k_main.c |    4 ++--
>  drivers/net/ethernet/intel/igb/igb_main.c     |    3 +--
>  drivers/net/ethernet/intel/ixgb/ixgb_main.c   |    6 +++---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |    4 ++--
>  6 files changed, 10 insertions(+), 11 deletions(-)


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)