lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 14 Dec 2014 20:23:51 +0100 From: Jiri Pirko <jiri@...nulli.us> To: Or Gerlitz <ogerlitz@...lanox.com> Cc: "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org, gospo@...ulusnetworks.com, jhs@...atatu.com, john.r.fastabend@...el.com Subject: Re: [PATCH net] net: Disallow providing non zero VLAN ID for NIC drivers FDB add flow Sun, Dec 14, 2014 at 05:19:05PM CET, ogerlitz@...lanox.com wrote: >The current implementations all use dev_uc_add_excl() and such whose API >doesn't support vlans, so we can't make it with NICs HW for now. > >Fixes: f6f6424ba773 ('net: make vid as a parameter for ndo_fdb_add/ndo_fdb_del') Maybe I'm missing something, but this commit did not introduce the problem. If was there already before when NDA_VLAN was set and ignored. But other than this. I like the patch Reviewed-by: Jiri Pirko <jiri@...nulli.us> >Signed-off-by: Or Gerlitz <ogerlitz@...lanox.com> >--- > drivers/net/ethernet/intel/i40e/i40e_main.c | 5 +++++ > net/core/rtnetlink.c | 5 +++++ > 2 files changed, 10 insertions(+), 0 deletions(-) > >diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c >index 0a7ea4c..a5f2660 100644 >--- a/drivers/net/ethernet/intel/i40e/i40e_main.c >+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c >@@ -7549,6 +7549,11 @@ static int i40e_ndo_fdb_add(struct ndmsg *ndm, struct nlattr *tb[], > if (!(pf->flags & I40E_FLAG_SRIOV_ENABLED)) > return -EOPNOTSUPP; > >+ if (vid) { >+ pr_info("%s: vlans aren't supported yet for dev_uc|mc_add()\n", dev->name); >+ return -EINVAL; >+ } >+ > /* Hardware does not support aging addresses so if a > * ndm_state is given only allow permanent addresses > */ >diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c >index d06107d..9cf6fe9 100644 >--- a/net/core/rtnetlink.c >+++ b/net/core/rtnetlink.c >@@ -2368,6 +2368,11 @@ int ndo_dflt_fdb_add(struct ndmsg *ndm, > return err; > } > >+ if (vid) { >+ pr_info("%s: vlans aren't supported yet for dev_uc|mc_add()\n", dev->name); >+ return err; >+ } >+ > if (is_unicast_ether_addr(addr) || is_link_local_ether_addr(addr)) > err = dev_uc_add_excl(dev, addr); > else if (is_multicast_ether_addr(addr)) >-- >1.7.1 > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists