netdev - Re: [PATCH net] enic: fix rx skb checksum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20141218.124910.2223321203114038063.davem@davemloft.net>
Date:	Thu, 18 Dec 2014 12:49:10 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	jay.vosburgh@...onical.com
Cc:	eric.dumazet@...il.com, _govind@....com, netdev@...r.kernel.org,
	ssujith@...co.com, benve@...co.com, jbenc@...hat.com,
	sassmann@...hat.com
Subject: Re: [PATCH net] enic: fix rx skb checksum

From: Jay Vosburgh <jay.vosburgh@...onical.com>
Date: Thu, 18 Dec 2014 09:39:27 -0800

> @@ -1694,6 +1694,7 @@ int __dev_forward_skb(struct net_device *dev, struct sk_buff *skb)
>  
>  	skb_scrub_packet(skb, true);
>  	skb->protocol = eth_type_trans(skb, dev);
> +	skb_postpull_rcsum(skb, eth_hdr(skb), ETH_HLEN);
>  
>  	return 0;
>  }
> 
> 	I'd very much appreciate comments from someone who knows the
> checksum logic better than I do as to whether this is a reasonable thing
> to do.

This looks quite reasonable to me.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html