lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 31 Dec 2014 09:45:42 -0800 From: Jeremiah Mahler <jmmahler@...il.com> To: roopa@...ulusnetworks.com Cc: netdev@...r.kernel.org, hemminger@...tta.com, vyasevic@...hat.com, sfeldma@...il.com, wkok@...ulusnetworks.com Subject: Re: [PATCH net-next v2 1/2] bridge: new attribute and flags to represent vlan info lists and ranges Roopa, On Wed, Dec 31, 2014 at 08:48:52AM -0800, roopa@...ulusnetworks.com wrote: > From: Roopa Prabhu <roopa@...ulusnetworks.com> > > This patch adds (as suggested by scott feldman), > - new netlink attribute IFLA_BRIDGE_VLAN_INFO_LIST to represent > vlan list > - And bridge_vlan_info flags BRIDGE_VLAN_INFO_RANGE_START and > BRIDGE_VLAN_INFO_RANGE_END to indicate start and end of vlan range > > Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com> > --- > include/uapi/linux/if_bridge.h | 4 ++++ > net/bridge/br_netlink.c | 1 + > 2 files changed, 5 insertions(+) > > diff --git a/include/uapi/linux/if_bridge.h b/include/uapi/linux/if_bridge.h > index b03ee8f..fa468aa 100644 > --- a/include/uapi/linux/if_bridge.h > +++ b/include/uapi/linux/if_bridge.h > @@ -112,12 +112,14 @@ struct __fdb_entry { > * [IFLA_BRIDGE_FLAGS] > * [IFLA_BRIDGE_MODE] > * [IFLA_BRIDGE_VLAN_INFO] > + * [IFLA_BRIDGE_VLAN_INFO_LIST] > * } > */ > enum { > IFLA_BRIDGE_FLAGS, > IFLA_BRIDGE_MODE, > IFLA_BRIDGE_VLAN_INFO, > + IFLA_BRIDGE_VLAN_INFO_LIST, > __IFLA_BRIDGE_MAX, > }; > #define IFLA_BRIDGE_MAX (__IFLA_BRIDGE_MAX - 1) > @@ -125,6 +127,8 @@ enum { > #define BRIDGE_VLAN_INFO_MASTER (1<<0) /* Operate on Bridge device as well */ > #define BRIDGE_VLAN_INFO_PVID (1<<1) /* VLAN is PVID, ingress untagged */ > #define BRIDGE_VLAN_INFO_UNTAGGED (1<<2) /* VLAN egresses untagged */ > +#define BRIDGE_VLAN_INFO_RANGE_START (1<<3) /* VLAN is start of vlan range */ > +#define BRIDGE_VLAN_INFO_RANGE_END (1<<4) /* VLAN is end of vlan range */ > You add these here but you don't use them until the next patch. If they were wrong a bisect would point to the next patch. I would add them in the next patch where you start to use them. > struct bridge_vlan_info { > __u16 flags; > diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c > index 9f5eb55..492ef6a 100644 > --- a/net/bridge/br_netlink.c > +++ b/net/bridge/br_netlink.c > @@ -223,6 +223,7 @@ static const struct nla_policy ifla_br_policy[IFLA_MAX+1] = { > [IFLA_BRIDGE_MODE] = { .type = NLA_U16 }, > [IFLA_BRIDGE_VLAN_INFO] = { .type = NLA_BINARY, > .len = sizeof(struct bridge_vlan_info), }, > + [IFLA_BRIDGE_VLAN_INFO_LIST] = { .type = NLA_NESTED, }, > }; > > static int br_afspec(struct net_bridge *br, > -- > 1.7.10.4 > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- - Jeremiah Mahler -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists