netdev - Re: [PATCH] Drivers: isdn: gigaset: checkpatch cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141231174936.GB1922@hudson.localdomain>
Date:	Wed, 31 Dec 2014 09:49:36 -0800
From:	Jeremiah Mahler <jmmahler@...il.com>
To:	Bas Peters <baspeters93@...il.com>
Cc:	hjlipp@....de, tilman@...p.cc, isdn@...ux-pingi.de,
	gigaset307x-common@...ts.sourceforge.net, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Drivers: isdn: gigaset: checkpatch cleanup

Bas,

On Wed, Dec 31, 2014 at 06:34:58PM +0100, Bas Peters wrote:
> Fixed many checkpatch.pl complaints, ranging from whitespace issues to
> reportedly deprecated function and macro usage.
> 
One patch should fix one type of problem.  This needs to be broken up
in to individual patches.

> I have not been able to test the code as I do not have access to the
> hardware but since no new features were really added I don't think that
> should pose a problem.
> 
> There are still some checkpatch complaints, particularly concerning
> potentially unnecessary 'out of memory' messages. I will provide patches
> for these complaints when I figure out the reason behind it and what to
> do about it.
> 
> NOTE: This is my first patch (ever). I have attempted to follow all
> guidelines provided, but I probably will have missed some. If you have
> any comments regarding the quality of this patch or suggestions as to
> what I could do better in the future, please let me know.
> 
You are ambitious.  I would suggest trying a smaller patch first to
make sure you are doing everything right.

> Signed-off-by: Bas Peters <baspeters93@...il.com>
> ---
>  drivers/isdn/gigaset/asyncdata.c   |  9 +++--
>  drivers/isdn/gigaset/bas-gigaset.c | 80 ++++++++++++++++++++------------------
>  drivers/isdn/gigaset/capi.c        |  5 ++-
>  drivers/isdn/gigaset/common.c      |  8 ++--
>  drivers/isdn/gigaset/ev-layer.c    | 38 +++++++++++-------
>  drivers/isdn/gigaset/gigaset.h     |  4 +-
>  drivers/isdn/gigaset/i4l.c         | 12 +++---
>  drivers/isdn/gigaset/interface.c   | 10 ++---
>  drivers/isdn/gigaset/isocdata.c    |  3 ++
>  drivers/isdn/gigaset/proc.c        | 17 +++++---
>  drivers/isdn/gigaset/usb-gigaset.c | 46 +++++++++++++++-------
>  11 files changed, 141 insertions(+), 91 deletions(-)
> 
> diff --git a/drivers/isdn/gigaset/asyncdata.c b/drivers/isdn/gigaset/asyncdata.c
[...]

-- 
- Jeremiah Mahler
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html