netdev - Re: [PATCH net-next] net: More vlan tests before registering netdevice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 02 Jan 2015 15:56:21 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	Yuval.Mintz@...gic.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: More vlan tests before registering
 netdevice

From: Yuval Mintz <Yuval.Mintz@...gic.com>
Date: Wed, 31 Dec 2014 08:35:36 +0200

> When register_netdevice() is called, netdevice's vlan filtering feature
> and supplied callbacks are checked to see the vlan implementation is
> not buggy.
> This adds an additional test - see that the vlan_features were filled
> correctly, as the vlan devices inherits those as its own features;
> Incorrect values set there would later prevent the vlan interface from being
> registered itself [as it doesn't implement the filtering ndos].
> 
> Signed-off-by: Yuval Mintz <Yuval.Mintz@...gic.com>
 ...
> Not sure why take such a defensive approach regarding this feature.
> Perhaps it would have been better to simply remove these checks altogether.

I guess this is fine as a defensive test, so I'll apply this.

But do you actually know of any devices which have violated this rule
either now or in the past?  I quickly tried to audit the entire tree
for this right now and found no problems.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html