netdev - Re: [PATCH net-next] net: More vlan tests before registering netdevice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150102.155743.1836127158044264148.davem@davemloft.net>
Date:	Fri, 02 Jan 2015 15:57:43 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	Yuval.Mintz@...gic.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: More vlan tests before registering
 netdevice

From: David Miller <davem@...emloft.net>
Date: Fri, 02 Jan 2015 15:56:21 -0500 (EST)

> From: Yuval Mintz <Yuval.Mintz@...gic.com>
> Date: Wed, 31 Dec 2014 08:35:36 +0200
> 
>> When register_netdevice() is called, netdevice's vlan filtering feature
>> and supplied callbacks are checked to see the vlan implementation is
>> not buggy.
>> This adds an additional test - see that the vlan_features were filled
>> correctly, as the vlan devices inherits those as its own features;
>> Incorrect values set there would later prevent the vlan interface from being
>> registered itself [as it doesn't implement the filtering ndos].
>> 
>> Signed-off-by: Yuval Mintz <Yuval.Mintz@...gic.com>
>  ...
>> Not sure why take such a defensive approach regarding this feature.
>> Perhaps it would have been better to simply remove these checks altogether.
> 
> I guess this is fine as a defensive test, so I'll apply this.

Actually, reverted.

Nothing makes me more angry than a patch that wasn't even build tested:

net/core/dev.c: In function ‘register_netdevice’:
net/core/dev.c:6285:57: error: expected ‘)’ before ‘{’ token
net/core/dev.c:6378:1: error: expected expression before ‘}’ token
net/core/dev.c:6277:4: error: label ‘out’ used but not defined
net/core/dev.c:6378:1: warning: control reaches end of non-void function [-Wreturn-type]