netdev - Re: [PATCH iproute2 1/3] ss: Unify unix stats output from netlink and proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150103095606.03b741ed@urahara>
Date:	Sat, 3 Jan 2015 09:56:06 -0800
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Vadim Kochan <vadim4j@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 1/3] ss: Unify unix stats output from netlink
 and proc

Looks good, but could you fix some minor style things.

On Sat,  3 Jan 2015 02:44:35 +0200
Vadim Kochan <vadim4j@...il.com> wrote:

>  
> -static void unix_list_print(struct unixstat *list, struct filter *f)
> +static int unix_type_skip(struct unixstat *s, struct filter *f)
> +{

Please use bool for logical true/false value in new code.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html