lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sat, 3 Jan 2015 09:57:07 -0800
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Vadim Kochan <vadim4j@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 3/3] ss: Filtering logic changing, with fixes

On Sat,  3 Jan 2015 02:44:37 +0200
Vadim Kochan <vadim4j@...il.com> wrote:

> +struct filter default_dbs[MAX_DB] = {
> +	[TCP_DB] = {
> +		.states   = SS_CONN,
> +		.families = (1 << AF_INET) | (1 << AF_INET6),
> +	},

I like table driven code, so this is good. But please make
mark the table as const.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ