netdev - Re: [PATCH net-next v3 1/4] net: bcmgenet: bcmgenet_init_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150104.234633.1102329264651728598.davem@davemloft.net>
Date:	Sun, 04 Jan 2015 23:46:33 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	pgynther@...gle.com
Cc:	netdev@...r.kernel.org, f.fainelli@...il.com
Subject: Re: [PATCH net-next v3 1/4] net: bcmgenet: bcmgenet_init_tx_ring()
 cleanup

From: Petri Gynther <pgynther@...gle.com>
Date: Sat,  3 Jan 2015 23:45:23 -0800 (PST)

> Signed-off-by: Petri Gynther <pgynther@...gle.com>

I'm not applying patches like this with not even a minor
explanation of what kind of cleanups are happening.

> -	/* Disable rate control for now */
>  	bcmgenet_tdma_ring_writel(priv, index, flow_period_val,
>  				  TDMA_FLOW_PERIOD);

And I think this comment, and the others you are removing are
absolutely appropriate and should not be removed.

Also, what value is there in renaming the function argument
'write_ptr' to 'start_ptr'?  I think both names are equally
clear.

You have to provide explanations and justifications in the commit log
message of your changes.

I'm not applying this series, sorry.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html