lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Sun, 04 Jan 2015 23:46:33 -0500 (EST)
From:	David Miller <>
Subject: Re: [PATCH net-next v3 1/4] net: bcmgenet: bcmgenet_init_tx_ring()

From: Petri Gynther <>
Date: Sat,  3 Jan 2015 23:45:23 -0800 (PST)

> Signed-off-by: Petri Gynther <>

I'm not applying patches like this with not even a minor
explanation of what kind of cleanups are happening.

> -	/* Disable rate control for now */
>  	bcmgenet_tdma_ring_writel(priv, index, flow_period_val,

And I think this comment, and the others you are removing are
absolutely appropriate and should not be removed.

Also, what value is there in renaming the function argument
'write_ptr' to 'start_ptr'?  I think both names are equally

You have to provide explanations and justifications in the commit log
message of your changes.

I'm not applying this series, sorry.
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists