[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20150104.234838.596521437683943688.davem@davemloft.net>
Date: Sun, 04 Jan 2015 23:48:38 -0500 (EST)
From: David Miller <davem@...emloft.net>
To: me@...tis.eu
Cc: linux-kernel@...r.kernel.org, jitendra.kalsaria@...gic.com,
ron.mercer@...gic.com, linux-driver@...gic.com,
netdev@...r.kernel.org
Subject: Re: [PATCH] Fix an infinite retry-loop
From: Giel van Schijndel <me@...tis.eu>
Date: Sun, 4 Jan 2015 19:04:55 +0100
> This was clearly intended as a retry-10-times loop, but due to the
> absence of code incrementing the loop-counter it was practically a
> retry-forever loop.
>
> Rewritten it as a for-loop as well to make the loop-counter increment
> (as well as its potential absence) easier to spot.
Besides missing the Signoff, you also did not write your
Subject line properly.
You should format it as:
Subject: [PATCH] ${SUBSYSTEM_PREFIX}: Description.
Where ${SUBSYSTEM_PREFIX} should be "qlogic: " in this
case.
Do not fix this by replying to this email, instead make a new
fresh patch posting to the lists.
This also applied to all of your other submissions, they all
need to be fixed up in this manner at the very least.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists