netdev - Re: [PATCH iproute2 -next v2] ip: route: add congestion control metric

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150107150657.1defa6bd@urahara>
Date:	Wed, 7 Jan 2015 15:06:57 -0800
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Daniel Borkmann <dborkman@...hat.com>
Cc:	fw@...len.de, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 -next v2] ip: route: add congestion control
 metric

On Wed,  7 Jan 2015 12:28:18 +0100
Daniel Borkmann <dborkman@...hat.com> wrote:

> +			if (i != RTAX_CC_ALGO)
> +				val = *(unsigned *)RTA_DATA(mxrta[i]);

Please use rta_getattr_u32 here.

Yes, I know you copied old code, but the old code predated the helper
functions.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html