netdev - Re: [PATCH iproute2 -next v2] ip: route: add congestion control metric

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54ADC34C.9030505@redhat.com>
Date:	Thu, 08 Jan 2015 00:37:48 +0100
From:	Daniel Borkmann <dborkman@...hat.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
CC:	fw@...len.de, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 -next v2] ip: route: add congestion control metric

On 01/08/2015 12:06 AM, Stephen Hemminger wrote:
> On Wed,  7 Jan 2015 12:28:18 +0100
> Daniel Borkmann <dborkman@...hat.com> wrote:
>
>> +			if (i != RTAX_CC_ALGO)
>> +				val = *(unsigned *)RTA_DATA(mxrta[i]);
>
> Please use rta_getattr_u32 here.
>
> Yes, I know you copied old code, but the old code predated the helper
> functions.

No problem, that looks better indeed. Will add it.

Btw, while we're on the topic, we ignore errors for all rta_addattr*()
functions f.e. in iproute_modify(). I think at least we should undo the
mxlock in case of an error (or bail out entirely as a different option).

Thanks,
Daniel
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html