netdev - RE: [net-next 10/17] i40e: clean up PTP log messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1CAC9AB0@AcuExch.aculab.com>
Date:	Thu, 15 Jan 2015 12:34:59 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'Jeff Kirsher' <jeffrey.t.kirsher@...el.com>,
	"davem@...emloft.net" <davem@...emloft.net>
CC:	Shannon Nelson <shannon.nelson@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"nhorman@...hat.com" <nhorman@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>,
	"jogreene@...hat.com" <jogreene@...hat.com>,
	Jacob Keller <jacob.e.keller@...el.com>
Subject: RE: [net-next 10/17] i40e: clean up PTP log messages

From: Jeff Kirsher
> From: Shannon Nelson <shannon.nelson@...el.com>
> 
> The netdev name at init time often defaults to eth0 but later gets changed
> by UDEV, so printing it here is misleading.

Without the interface name you stand zero chance of working out which one it is.
With it, and provided all the interface renames get into dmesg, you stand
at least some chance.

If you have several interfaces that use the same driver, but are subtly
different you can have a hard enough time as it is working out what is
going on.

I know it is too late now, but UDEV should never have been allowed to
rename devices, instead it should have added 'alias' names.
Then you would stand some chance of working out which was which.

> This patch removes the name
> from the log messages, and removes the use of __func__ as we're not using
> that any more in the driver.

I can't remember, do these messages contain the name of the driver (as
well as the device id string).
You might need some help when grepping the kernel source to find where
the messages are coming from.

	David

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html