[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <54B7B4E7.8030108@suse.de>
Date: Thu, 15 Jan 2015 13:39:03 +0100
From: Alexander Graf <agraf@...e.de>
To: Arnd Bergmann <arnd@...db.de>,
Ding Tianhong <dingtianhong@...wei.com>
CC: robh+dt@...nel.org, davem@...emloft.net, grant.likely@...aro.org,
sergei.shtylyov@...entembedded.com,
linux-arm-kernel@...ts.infradead.org, eric.dumazet@...il.com,
xuwei5@...ilicon.com, zhangfei.gao@...aro.org,
netdev@...r.kernel.org, devicetree@...r.kernel.org,
linux@....linux.org.uk
Subject: Re: [PATCH net-next v13 0/3] add hisilicon hip04 ethernet driver
On 15.01.15 10:42, Arnd Bergmann wrote:
> On Thursday 15 January 2015 16:37:23 Ding Tianhong wrote:
>> On 2015/1/14 18:19, Alexander Graf wrote:
>>>
>>> >From a 10000 feet perspective it looks like two problems to me
>>>
>>> 1) Allocation failure doesn't get handled properly somewhere
>
> This is the bug that Eric pointed out as well.
>
>>> 2) We fail to allocate with order=0 - I don't see why
>
> GFP_ATOMIC. When allocating from a the napi poll function in softirq
> context, you have to use nonblocking allocations, which occasionally
> fail. This should not cause any harm other than dropped packets.
>
>> is it easy to repetition this bug? how big is your memory on your board,
>> is it happened in your previous hip04 driver?
>
> It should be independent of memory size, but may be more likely if you
> don't have swap space configured.
With the previous driver I was unable to get this far - I ended up in
random memory corruption and had a ~90% packet loss after about an hour
of uptime.
I'm not sure whether it's easy to reproduce, I merely started up a few
VMs, did some disk I/O and started to compile QEMU in the background ;).
I'll happily give your follow up patch that's going to fix the memory
allocation problems a try though.
Alex
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists