netdev - Re: [net-next 13/17] i40e: AQ API updates for new commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ3xEMgim-97TRkGKfVRdyE49-PRR-mt11Ckq1uOuJuZbvXZcQ@mail.gmail.com>
Date:	Thu, 15 Jan 2015 20:04:52 +0200
From:	Or Gerlitz <gerlitz.or@...il.com>
To:	"Nelson, Shannon" <shannon.nelson@...el.com>
Cc:	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	David Miller <davem@...emloft.net>,
	Linux Netdev List <netdev@...r.kernel.org>,
	"nhorman@...hat.com" <nhorman@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>,
	"jogreene@...hat.com" <jogreene@...hat.com>,
	"Krawczyk, Kamil" <kamil.krawczyk@...el.com>
Subject: Re: [net-next 13/17] i40e: AQ API updates for new commands

On Thu, Jan 15, 2015 at 7:19 PM, Nelson, Shannon
<shannon.nelson@...el.com> wrote:
>> From: Or Gerlitz [mailto:gerlitz.or@...il.com]
>> Sent: Thursday, January 15, 2015 9:14 AM
>>
>> On Thu, Jan 15, 2015 at 2:19 PM, Jeff Kirsher
>> <jeffrey.t.kirsher@...el.com> wrote:
>> > From: Shannon Nelson <shannon.nelson@...el.com>
>> >
>> > Add lldp control commands, add oem ocsd and ocbb commands, and fix up
>> > NVM config read and write data structs.
>>
>> Sounds to me like a proofed nightmare for someone doing future
>> bisection and landing here... we want kernel patches to be made of
>> basically one logical change, right?
>
> Yes, but note that these are mostly API additions for transactions that aren't used in the code quite yet.  There are a couple of defines that get changed as well, but they aren't used yet either else they'd be accompanied by related code changes.


So NVM config read and write data structs aren't in use? anyway, this
way or another, I think we should stick to the practice of avoiding to
load few different changes on one patch
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html