netdev - Re: [net-next 10/17] i40e: clean up PTP log messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150115.153846.1450539700341201746.davem@davemloft.net>
Date:	Thu, 15 Jan 2015 15:38:46 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	shannon.nelson@...el.com
Cc:	David.Laight@...LAB.COM, jeffrey.t.kirsher@...el.com,
	netdev@...r.kernel.org, nhorman@...hat.com, sassmann@...hat.com,
	jogreene@...hat.com, jacob.e.keller@...el.com
Subject: Re: [net-next 10/17] i40e: clean up PTP log messages

From: "Nelson, Shannon" <shannon.nelson@...el.com>
Date: Thu, 15 Jan 2015 15:01:42 +0000

> The dev_info() messages have the PCI device and function number in the string, so it's really not too hard to track down the resulting netdev port:
> Jan 13 15:46:55 snelson3-cup kernel: [621235.401627] i40e 0000:84:00.1: PHC enabled
> 
> Later messages use netdev_info() and have both the device number and the netdev name:
> Jan 13 15:46:56 snelson3-cup kernel: [621236.508868] i40e 0000:04:00.1 p261p2: NIC Link is Up 10 Gbps Full Duplex, Flow Control: None
> 
> Note that the driver name appears in both as well.

I think we should consistently provide the netdev name as soon as
register_netdevice() returns.

It is unwise for every driver to have their own private policy on
this.

Please change this back.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html