netdev - Re: [PATCH 3/3] genetlink: synchronize socket closing and family removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1421355306.1962.14.camel@sipsolutions.net>
Date:	Thu, 15 Jan 2015 21:55:06 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, jeff.layton@...marydata.com,
	sedat.dilek@...il.com
Subject: Re: [PATCH 3/3] genetlink: synchronize socket closing and family
 removal

On Thu, 2015-01-15 at 14:50 -0500, David Miller wrote:
> From: Johannes Berg <johannes@...solutions.net>
> Date: Thu, 15 Jan 2015 12:04:45 +0100
> 
> > +		atomic_dec(&genl_sk_destructing_cnt);
> > +		printk(KERN_DEBUG "dec destructing\n");
> > +		wake_up(&genl_sk_destructing_waitq);
> 
> Hmmm, maybe only wakeup if "!atomic_dec_and_test()"?

Yes, good point.

And, umm, how the hell did I manage to leave the printk() in there?

johannes


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html