netdev - RE: [net-next 10/17] i40e: clean up PTP log messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <FC41C24E35F18A40888AACA1A36F3E418ADD4215@fmsmsx115.amr.corp.intel.com>
Date:	Thu, 15 Jan 2015 22:44:48 +0000
From:	"Nelson, Shannon" <shannon.nelson@...el.com>
To:	David Miller <davem@...emloft.net>
CC:	"David.Laight@...LAB.COM" <David.Laight@...LAB.COM>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"nhorman@...hat.com" <nhorman@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>,
	"jogreene@...hat.com" <jogreene@...hat.com>,
	"Keller, Jacob E" <jacob.e.keller@...el.com>
Subject: RE: [net-next 10/17] i40e: clean up PTP log messages

> From: David Miller [mailto:davem@...emloft.net]
> Sent: Thursday, January 15, 2015 12:39 PM
> 
> From: "Nelson, Shannon" <shannon.nelson@...el.com>
> Date: Thu, 15 Jan 2015 15:01:42 +0000
> 
> > The dev_info() messages have the PCI device and function number in the
> string, so it's really not too hard to track down the resulting netdev
> port:
> > Jan 13 15:46:55 snelson3-cup kernel: [621235.401627] i40e
> 0000:84:00.1: PHC enabled
> >
> > Later messages use netdev_info() and have both the device number and
> the netdev name:
> > Jan 13 15:46:56 snelson3-cup kernel: [621236.508868] i40e 0000:04:00.1
> p261p2: NIC Link is Up 10 Gbps Full Duplex, Flow Control: None
> >
> > Note that the driver name appears in both as well.
> 
> I think we should consistently provide the netdev name as soon as
> register_netdevice() returns.
> 
> It is unwise for every driver to have their own private policy on
> this.
> 
> Please change this back.

Sure, we can simply drop this patch.

<useless whine>
Yes, the driver should print the unvarnished truth.  What's frustrating about UDEV is that it ends up making the driver look like it is confused and/or lying in the log messages.  We'd prefer to minimize this unnecessary user-confusion where possible.
</useless whine>

sln



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html