netdev - Re: [PATCH iproute2 1/2] lib: fix warning in namespace.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150115113347.GA17587@angus-think.wlc.globallogic.com>
Date:	Thu, 15 Jan 2015 13:33:47 +0200
From:	Vadim Kochan <vadim4j@...il.com>
To:	Nicolas Dichtel <nicolas.dichtel@...nd.com>
Cc:	shemminger@...tta.com, netdev@...r.kernel.org,
	Vadim Kochan <vadim4j@...il.com>
Subject: Re: [PATCH iproute2 1/2] lib: fix warning in namespace.h

On Thu, Jan 15, 2015 at 11:36:24AM +0100, Nicolas Dichtel wrote:
> Warning was:
> In file included from bridge.c:16:0:
> ../include/namespace.h:33:12: warning: ‘setns’ defined but not used [-Wunused-function]
> 
> CC: Vadim Kochan <vadim4j@...il.com>
> Fixes: eb67e4498aec ("lib: Add netns_switch func for change network namespace")
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
> ---
>  include/namespace.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/namespace.h b/include/namespace.h
> index b8c5cad6aaa2..28a4223b3eb2 100644
> --- a/include/namespace.h
> +++ b/include/namespace.h
> @@ -30,7 +30,7 @@
>  #endif
>  
>  #ifndef HAVE_SETNS
> -static int setns(int fd, int nstype)
> +static inline int setns(int fd, int nstype)
>  {
>  #ifdef __NR_setns
>  	return syscall(__NR_setns, fd, nstype);
> -- 
> 2.1.0
> 
Thank You Nicolas!
I have to do more testing before send a patches.

Thanks,
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html