netdev - Re: [PATCH for 3.19 2/3] rtlwifi: Fix handling of new style descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877fwoxo7g.fsf@kamboji.qca.qualcomm.com>
Date:	Thu, 15 Jan 2015 13:44:51 +0200
From:	Kalle Valo <kvalo@...eaurora.org>
To:	Larry Finger <Larry.Finger@...inger.net>
Cc:	linux-wireless@...r.kernel.org, Troy Tan <troy_tan@...lsil.com.cn>,
	netdev@...r.kernel.org
Subject: Re: [PATCH for 3.19 2/3] rtlwifi: Fix handling of new style descriptors

Larry Finger <Larry.Finger@...inger.net> writes:

> From: Troy Tan <troy_tan@...lsil.com.cn>
>
> The hardware and firmware for the RTL8192EE utilize a FIFO list of
> descriptors. There were some problems with the initial implementation.
> The worst of these failed to detect that the FIFO was becoming full,
> which led to the device needing to be power cycled. As this condition
> is not relevant to most of the devices supported by rtlwifi, a callback
> routine was added to detect this situation. This patch implements the
> necessary changes in the pci handler.
>
> Signed-off-by: Troy Tan <troy_tan@...lsil.com.cn>
> Signed-off-by: Larry Finger <Larry.Finger@...inger.net>

[...]

> --- a/drivers/net/wireless/rtlwifi/wifi.h
> +++ b/drivers/net/wireless/rtlwifi/wifi.h
> @@ -2172,6 +2172,7 @@ struct rtl_hal_ops {
>  	void (*add_wowlan_pattern)(struct ieee80211_hw *hw,
>  				   struct rtl_wow_pattern *rtl_pattern,
>  				   u8 index);
> +	u16 (*get_available_desc)(struct ieee80211_hw *hw, u8 q_idx);

I don't see this op set anywhere within the patch. Is that correct or
did I miss something?

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html