netdev - Re: [PATCH] phonet netlink: allow multiple messages per skb in route dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1421698484.1965.44.camel@sipsolutions.net>
Date:	Mon, 19 Jan 2015 21:14:44 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Rémi Denis-Courmont <remi@...lab.net>
Cc:	netdev@...r.kernel.org, Sakari Ailus <sakari.ailus@...ia.com>,
	Remi Denis-Courmont <courmisch@...il.com>
Subject: Re: [PATCH] phonet netlink: allow multiple messages per skb in
 route dump

On Mon, 2015-01-19 at 22:11 +0200, Rémi Denis-Courmont wrote:
> Le lundi 19 janvier 2015, 12:15:24 Johannes Berg a écrit :
> > From: Johannes Berg <johannes.berg@...el.com>
> > 
> > My previous patch to this file changed the code to be bug-compatible
> > towards userspace. Unless userspace (which I wasn't able to find)
> > implements the dump reader by hand in a wrong way, this isn't needed.
> 
> The canonical userspace is there (specifically src/pnroute.c):
> https://gitorious.org/meego-cellular/phonet-utils/

Ah, cool.

> AFAICT, it should work either way. By now, I expect what's left of the 
> Maemo/Meego/Mer/whatever community has forked or rewritten it though.

The loop

	for (struct nlmsghdr *nlh = (struct nlmsghdr *)&req;
	     NLMSG_OK (nlh, (size_t)ret); nlh = NLMSG_NEXT (nlh, ret))

should make it do the right thing, I agree.

johannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html