netdev - Re: [PATCH] phonet netlink: allow multiple messages per skb in route dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150119.162046.967451324075209369.davem@davemloft.net>
Date:	Mon, 19 Jan 2015 16:20:46 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	johannes@...solutions.net
Cc:	netdev@...r.kernel.org, sakari.ailus@...ia.com,
	courmisch@...il.com, johannes.berg@...el.com
Subject: Re: [PATCH] phonet netlink: allow multiple messages per skb in
 route dump

From: Johannes Berg <johannes@...solutions.net>
Date: Mon, 19 Jan 2015 12:15:24 +0100

> From: Johannes Berg <johannes.berg@...el.com>
> 
> My previous patch to this file changed the code to be bug-compatible
> towards userspace. Unless userspace (which I wasn't able to find)
> implements the dump reader by hand in a wrong way, this isn't needed.
> If it uses libnl or similar code putting multiple messages into a
> single SKB is far more efficient.
> 
> Change the code to do this. While at it, also clean it up and don't
> use so many variables - just store the address in the callback args
> directly.
> 
> Signed-off-by: Johannes Berg <johannes.berg@...el.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html