netdev - Re: [PATCH net-next] net: ipv6: Add sysctl entry to disable MTU updates from RA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150119.155807.377681769985591321.davem@davemloft.net>
Date:	Mon, 19 Jan 2015 15:58:07 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	harouth@...eaurora.org
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: ipv6: Add sysctl entry to disable MTU
 updates from RA

From: Harout Hedeshian <harouth@...eaurora.org>
Date: Fri, 16 Jan 2015 18:02:38 -0700

> The kernel forcefully applies MTU values received in router
> advertisements provided the new MTU is less than the current. This
> behavior is undesirable when the user space is managing the MTU. Instead
> a sysctl flag 'accept_ra_mtu' is introduced such that the user space
> can control whether or not RA provided MTU updates should be applied. The
> default behavior is unchanged; user space must explicitly set this flag
> to 0 for RA MTUs to be ignored.
> 
> Signed-off-by: Harout Hedeshian <harouth@...eaurora.org>

A really sloppy submission, sorry I can't apply this.

> +	{ CTL_INT,	NET_IPV6_ACCEPT_RA_MTU,			"accept_ra_mtu" },

This isn't defined anywhere, you left out some file while creating
your patch.

kernel/sysctl_binary.c:526:13: error: ‘NET_IPV6_ACCEPT_RA_MTU’ undeclared here (not in a function)


> -	if (ndopts.nd_opts_mtu) {
> +	if (ndopts.nd_opts_mtu  && in6_dev->cnf.accept_ra_mtu) {

Too many spaced before the &&