netdev - RE: [PATCH net-next] net: ipv6: Add sysctl entry to disable MTU updates from RA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <000d01d0342f$4ee4f740$ecaee5c0$@codeaurora.org>
Date:	Mon, 19 Jan 2015 14:31:37 -0700
From:	"Harout Hedeshian" <harouth@...eaurora.org>
To:	"'David Miller'" <davem@...emloft.net>
Cc:	<netdev@...r.kernel.org>
Subject: RE: [PATCH net-next] net: ipv6: Add sysctl entry to disable MTU updates from RA



> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net]
> Sent: Monday, January 19, 2015 1:58 PM
> To: harouth@...eaurora.org
> Cc: netdev@...r.kernel.org
> Subject: Re: [PATCH net-next] net: ipv6: Add sysctl entry to disable MTU
> updates from RA
> 
> From: Harout Hedeshian <harouth@...eaurora.org>
> Date: Fri, 16 Jan 2015 18:02:38 -0700
> 
> > The kernel forcefully applies MTU values received in router
> > advertisements provided the new MTU is less than the current. This
> > behavior is undesirable when the user space is managing the MTU.
> > Instead a sysctl flag 'accept_ra_mtu' is introduced such that the user
> > space can control whether or not RA provided MTU updates should be
> > applied. The default behavior is unchanged; user space must explicitly
> > set this flag to 0 for RA MTUs to be ignored.
> >
> > Signed-off-by: Harout Hedeshian <harouth@...eaurora.org>
> 
> A really sloppy submission, sorry I can't apply this.
> 
> > +	{ CTL_INT,	NET_IPV6_ACCEPT_RA_MTU,
> 	"accept_ra_mtu" },

Yes, it appears include/uapi/linux/sysctl.h was missed during a rebase. I
will correct this.

> This isn't defined anywhere, you left out some file while creating your
patch.
> 
> kernel/sysctl_binary.c:526:13: error: ?NET_IPV6_ACCEPT_RA_MTU?
> undeclared here (not in a function)
> 
> 
> > -	if (ndopts.nd_opts_mtu) {
> > +	if (ndopts.nd_opts_mtu  && in6_dev->cnf.accept_ra_mtu) {
> 
> Too many spaced before the &&

Hmm. Looks like checkpatch.pl did does not catch this mistake. I only get
one warning about a line being too long:

harouth@...outh-lnx:/local/vg_local/lv_mainline/net_next/net-next$
./scripts/checkpatch.pl
0001-net-ipv6-Add-sysctl-entry-to-disable-MTU-updates-fro.patch
WARNING: line over 80 characters
#74: FILE: kernel/sysctl_binary.c:526:
+       { CTL_INT,      NET_IPV6_ACCEPT_RA_MTU,
"accept_ra_mtu" },

total: 0 errors, 1 warnings, 0 checks, 69 lines checked

0001-net-ipv6-Add-sysctl-entry-to-disable-MTU-updates-fro.patch has style
problems, please review.

I will send an updated patch (v2) in a moment.

V2 patch passes compilation in sysctl_binary.c:
harouth@...outh-lnx:/local/vg_local/lv_mainline/net_next/net-next$ make -j8
ARCH=um
..
  CC      kernel/sysctl.o
  CC      kernel/sysctl_binary.o
..

Thanks,
Harout

--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux
Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html