[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150119142803.GA5549@angus-think.wlc.globallogic.com>
Date: Mon, 19 Jan 2015 16:28:03 +0200
From: Vadim Kochan <vadim4j@...il.com>
To: Hagen Paul Pfeifer <hagen@...u.net>
Cc: Vadim Kochan <vadim4j@...il.com>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH iproute2 3/3] ss: Unify tcp stats output
On Mon, Jan 19, 2015 at 03:28:21PM +0100, Hagen Paul Pfeifer wrote:
> Hey Vadin,
>
> to make this short. We already discussed about changing the layout and
> Stephen nacked this. My proposal was to key:value the output. Because
> nearly all outputed data is already in this format - except the
> congestion control algo, ts, sack and tx'ed data. Where I proposed
> cc:<algo>. The key:value format has the advantages that the ordering
> do not mather anymore, An python parser would be something like split
> for whitespaces and later split for colon. Currently parsing this is a
> mess, see [1].
>
> Anyway, the more clever idea is to add an json outputer like already
> supported by some ss modules and get rid of this mess.
>
> Hagen
>
>
> [1] https://github.com/hgn/captcp/blob/master/captcp.py#L4861
Seems these patches will break your script at least for memory info
output.
I am thinking may be 1st of all it is better to make output in json
format and after this trying to make changes with human readability.
What do you think ?
Regards,
Vadim Kochan
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists