netdev - re: ipvlan: Initial check-in of the IPVLAN driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150119144011.GA19086@mwanda>
Date:	Mon, 19 Jan 2015 17:40:11 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	maheshb@...gle.com
Cc:	netdev@...r.kernel.org
Subject: re: ipvlan: Initial check-in of the IPVLAN driver.

Hello Mahesh Bandewar,

The patch 2ad7bf363841: "ipvlan: Initial check-in of the IPVLAN
driver." from Nov 23, 2014, leads to the following static checker
warning:

	drivers/net/ipvlan/ipvlan_core.c:380 ipvlan_process_v6_outbound()
	warn: 'dst' isn't an ERR_PTR

drivers/net/ipvlan/ipvlan_core.c
   378  
   379          dst = ip6_route_output(dev_net(dev), NULL, &fl6);
   380          if (IS_ERR(dst))
   381                  goto err;

The ip6_route_output() function is not documented but it always returns
a valid pointer.  I believe you are supposed to check something like:

		if (dst->error) {
			ret = dst->error;
			goto error;
		}

   382  
   383          skb_dst_drop(skb);
   384          skb_dst_set(skb, dst);

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html