netdev - Re: [PATCH net-next 1/2] tipc: fix excessive network event logging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1421947487.2702.1.camel@perches.com>
Date:	Thu, 22 Jan 2015 09:24:47 -0800
From:	Joe Perches <joe@...ches.com>
To:	erik.hugne@...csson.com
Cc:	richard.alpe@...csson.com, netdev@...r.kernel.org,
	jon.maloy@...csson.com, ying.xue@...driver.com,
	tipc-discussion@...ts.sourceforge.net
Subject: Re: [PATCH net-next 1/2] tipc: fix excessive network event logging

On Thu, 2015-01-22 at 17:10 +0100, erik.hugne@...csson.com wrote:
> From: Erik Hugne <erik.hugne@...csson.com>
> 
> If a large number of namespaces is spawned on a node and TIPC is
> enabled in each of these, the excessive printk tracing of network
> events will cause the system to grind down to a near halt.
> The traces are still of debug value, so instead of removing them
> completely we fix it by changing the link state and node availability
> logging debug traces.

Maybe some of these should be net_<level>_ratelimited(fmt, ...)

> diff --git a/net/tipc/link.c b/net/tipc/link.c
[]

> @@ -588,8 +588,8 @@ static void link_state_event(struct tipc_link *l_ptr, unsigned int event)
>  				l_ptr->fsm_msg_cnt++;
>  				link_set_timer(l_ptr, cont_intv / 4);
>  			} else {	/* Link has failed */
> -				pr_warn("%s<%s>, peer not responding\n",
> -					link_rst_msg, l_ptr->name);

Like this one.

> +				pr_debug("%s<%s>, peer not responding\n",
> +					 link_rst_msg, l_ptr->name);
>  				tipc_link_reset(l_ptr);
>  				l_ptr->state = RESET_UNKNOWN;
>  				l_ptr->fsm_msg_cnt = 0;

> @@ -380,8 +380,8 @@ static void node_lost_contact(struct tipc_node *n_ptr)
>  	char addr_string[16];
>  	u32 i;
>  
> -	pr_info("Lost contact with %s\n",
> -		tipc_addr_string_fill(addr_string, n_ptr->addr));
> +	pr_debug("Lost contact with %s\n",
> +		 tipc_addr_string_fill(addr_string, n_ptr->addr));
>  
>  	/* Flush broadcast link info associated with lost node */
>  	if (n_ptr->bclink.recv_permitted) {

And maybe this one too.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html