netdev - Re: [PATCH net-next 2/2] flow_dissector: add tipc support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1421947751.3471.12.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 22 Jan 2015 09:29:11 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	erik.hugne@...csson.com
Cc:	richard.alpe@...csson.com, netdev@...r.kernel.org,
	jon.maloy@...csson.com, ying.xue@...driver.com,
	tipc-discussion@...ts.sourceforge.net
Subject: Re: [PATCH net-next 2/2] flow_dissector: add tipc support

On Thu, 2015-01-22 at 17:10 +0100, erik.hugne@...csson.com wrote:
> From: Erik Hugne <erik.hugne@...csson.com>
> 
> The flows are hashed on the sending node address, which allows us
> to spread out the TIPC link processing to RPS enabled cores. There
> is no point to include the destination address in the hash as that
> will always be the same for all inbound links. We have experimented
> with a 3-tuple hash over [srcnode, sport, dport], but this showed to
> give slightly lower performance because of increased lock contention
> when the same link was handled by multiple cores.
> 
> Signed-off-by: Ying Xue <ying.xue@...driver.com>
> Signed-off-by: Erik Hugne <erik.hugne@...csson.com>
> Reviewed-by: Jon Maloy <jon.maloy@...csson.com>
> ---
>  net/core/flow_dissector.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
> index 4508493..beb83d1 100644
> --- a/net/core/flow_dissector.c
> +++ b/net/core/flow_dissector.c
> @@ -178,6 +178,20 @@ ipv6:
>  			return false;
>  		}
>  	}
> +	case htons(ETH_P_TIPC): {
> +		struct {
> +			__be32 pre[3];
> +			__be32 srcnode;
> +		} *hdr, _hdr;

Is this header defined somewhere in an include file ?

This looks a bit ugly to locally define the format...



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html