netdev - Re: [PATCH] net: ipv6: Make address flushing on ifdown optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150131.171709.1522796376864907030.davem@davemloft.net>
Date:	Sat, 31 Jan 2015 17:17:09 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dsahern@...il.com
Cc:	netdev@...r.kernel.org, hannes@...hat.com
Subject: Re: [PATCH] net: ipv6: Make address flushing on ifdown optional -
 v2

From: David Ahern <dsahern@...il.com>
Date: Wed, 28 Jan 2015 21:01:05 -0700

> @@ -3032,8 +3037,9 @@ static int addrconf_ifdown(struct net_device *dev, int how)
>  {
>  	struct net *net = dev_net(dev);
>  	struct inet6_dev *idev;
> -	struct inet6_ifaddr *ifa;
> +	struct inet6_ifaddr *ifa, *tmp;
>  	int state, i;
> +	struct list_head del_list;

Please order local variable declarations from longest to shortest line
(ie. reverse christmas tree) when it is easy to do so.

> +		/* 
> +		 * on NETDEV_DOWN events do not flush managed (user configured)
> +		 * addresses unless configured to do so. If the address is not
> +		 * deleted reset flags and state such that DAD is re-done on a
> + 		 * subsequent link up.
> + 		 */

Comments in the networking are to be formatted:

	/* Like
	 * this.
	 */

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html