lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAHA+R7Pnb1=rbhOTND6MygDM+oL7byMGFP5TmCxeNegb-o62zA@mail.gmail.com> Date: Tue, 3 Feb 2015 10:10:20 -0800 From: Cong Wang <cwang@...pensource.com> To: Ignacy Gawędzki <ignacy.gawedzki@...en-communications.fr>, netdev <netdev@...r.kernel.org> Subject: Re: [PATCH net v2] cls_api.c: Fix dumping of non-existing actions' stats. On Tue, Feb 3, 2015 at 10:05 AM, Ignacy Gawędzki <ignacy.gawedzki@...en-communications.fr> wrote: > In tcf_exts_dump_stats(), ensure that exts->actions is not empty before > accessing the first element of that list and calling tcf_action_copy_stats() > on it. This fixes some random segvs when adding filters of type "basic" with > no particular action. > > This also fixes the dumping of those "no-action" filters, which more often > than not made calls to tcf_action_copy_stats() fail and consequently netlink > attributes added by the caller to be removed by a call to nla_nest_cancel(). > > Fixes: 33be62715991 ("net_sched: act: use standard struct list_head") > Signed-off-by: Ignacy Gawędzki <ignacy.gawedzki@...en-communications.fr> Acked-by: Cong Wang <cwang@...pensource.com> Thanks! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists