netdev - Re: [PATCH net 1/1] cls_api.c: Fix dumping of non-existing actions' stats.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150204.202639.1658647887362952988.davem@davemloft.net>
Date:	Wed, 04 Feb 2015 20:26:39 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	ignacy.gawedzki@...en-communications.fr
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net 1/1] cls_api.c: Fix dumping of non-existing
 actions' stats.

From: Ignacy Gawędzki <ignacy.gawedzki@...en-communications.fr>
Date: Tue, 3 Feb 2015 18:32:51 +0100

> In tcf_exts_dump_stats(), ensure that exts->actions is not empty before
> accessing the first element of that list and calling tcf_action_copy_stats()
> on it.  This fixes some random segvs when adding filters of type "basic" with
> no particular action.
> 
> This also fixes the dumping of those "no-action" filters, which more often
> than not made calls to tcf_action_copy_stats() fail and consequently netlink
> attributes added by the caller to be removed by a call to nla_nest_cancel().
> 
> Signed-off-by: Ignacy Gawędzki <ignacy.gawedzki@...en-communications.fr>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html