netdev - Re: [PATCH net-next 1/2] pkt_sched: fq: avoid artificial bursts for clocked flows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1423001115.907.42.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Tue, 03 Feb 2015 14:05:15 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Kenneth Klette Jonassen <kennetkl@....uio.no>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 1/2] pkt_sched: fq: avoid artificial bursts for
 clocked flows

On Tue, 2015-02-03 at 19:51 +0000, Kenneth Klette Jonassen wrote:

> > 
> > ACK packets are not paced, ever.
> > 
> > This patch also allows skb->ooo_okay being set even if the DATA packet
> > immediately follows a train of ACK packets (as in typical RPC patterns)
> > 
> Could you please expand on this?
> 

If you followed netdev recently, you might have noticed I am currently
upstreaming patches that we tested more than 6 months at Google.

I am doing this in a non bursty way to ease David Miller work ;)

A hint is given in commit b2532eb9abd88384a
("tcp: fix ooo_okay setting vs Small Queues")

  * TODO: Ideally, in-flight pure ACK packets should not matter here.
  * One way to get this would be to set skb->truesize = 2 on them.

Thanks


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html