netdev - Re: [PATCH net-next v2 1/2] pkt_sched: fq: avoid artificial bursts for clocked flows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1423001164.907.43.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Tue, 03 Feb 2015 14:06:04 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Kenneth Klette Jonassen <kennetkl@....uio.no>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 1/2] pkt_sched: fq: avoid artificial bursts
 for clocked flows

On Tue, 2015-02-03 at 20:48 +0100, Kenneth Klette Jonassen wrote:
>  
> -	if (tb[TCA_FQ_INITIAL_QUANTUM])
> -		q->initial_quantum = nla_get_u32(tb[TCA_FQ_INITIAL_QUANTUM]);
> +	if (tb[TCA_FQ_INITIAL_QUANTUM]) {
> +		u32 initial_quantum = nla_get_u32(tb[TCA_FQ_INITIAL_QUANTUM]);
> +
> +		if (initial_quantum > q->quantum)
> +			q->initial_quantum = initial_quantum - q->quantum;
> +		else
> +			q->initial_quantum = 0;
> +	}

Please do not mix patches. This part already have been Acked by me.

Quite frankly I do not like this patch.

There is no rush, and you touch some critical infrastructure for us.

Always CC me on any fq change, do not assume I catch all netdev
messages.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html