lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <87siehnbgt.fsf@rasmusvillemoes.dk> Date: Sat, 07 Feb 2015 13:38:10 +0100 From: Rasmus Villemoes <linux@...musvillemoes.dk> To: Joe Perches <joe@...ches.com> Cc: "David S. Miller" <davem@...emloft.net>, Pravin B Shelar <pshelar@...ira.com>, Nicolas Dichtel <nicolas.dichtel@...nd.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Dan Carpenter <dan.carpenter@...cle.com> Subject: Re: [PATCH] vxlan: Wrong type passed to %pIS On Sat, Feb 07 2015, Joe Perches <joe@...ches.com> wrote: > On Sat, 2015-02-07 at 03:17 +0100, Rasmus Villemoes wrote: >> src_ip is a pointer to a union vxlan_addr, one member of which is a >> struct sockaddr. Passing a pointer to src_ip is wrong; one should pass >> the value of src_ip itself. Since %pIS formally expects something of >> type struct sockaddr*, let's pass a pointer to the appropriate union >> member, though this of course doesn't change the generated code. > > Hello Rasmus > > Are you finding these mismatches by hand or > are you using some tool? I've extended smatch to do format checking (mostly for the %p extensions; gcc already does all the other stuff just fine). I'll try and see if I can get it on github sometime in the coming week. Rasmus -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists