lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAM_iQpVisStscGn4QDxb7f3aeGT8nc6Ho3PPSFHM3NB5s2Ue0A@mail.gmail.com> Date: Sat, 7 Feb 2015 15:31:42 -0800 From: Cong Wang <xiyou.wangcong@...il.com> To: Rasmus Villemoes <linux@...musvillemoes.dk> Cc: "David S. Miller" <davem@...emloft.net>, Pravin B Shelar <pshelar@...ira.com>, Nicolas Dichtel <nicolas.dichtel@...nd.com>, Linux Kernel Network Developers <netdev@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] vxlan: Wrong type passed to %pIS On Sat, Feb 7, 2015 at 4:34 AM, Rasmus Villemoes <linux@...musvillemoes.dk> wrote: > On Sat, Feb 07 2015, Cong Wang <xiyou.wangcong@...il.com> wrote: > >> On Fri, Feb 6, 2015 at 6:17 PM, Rasmus Villemoes >> <linux@...musvillemoes.dk> wrote: >>> src_ip is a pointer to a union vxlan_addr, one member of which is a >>> struct sockaddr. Passing a pointer to src_ip is wrong; one should pass >>> the value of src_ip itself. Since %pIS formally expects something of >>> type struct sockaddr*, let's pass a pointer to the appropriate union >>> member, though this of course doesn't change the generated code. >>> >> >> >> It is a union, this doesn't harm. >> > > Just to be clear: This fixes a real bug. The minimal fix had been > > - src_mac, &rdst->remote_ip, &src_ip); > + src_mac, &rdst->remote_ip, src_ip); > > but I through in the cosmetic improvements while the line needed > changing anyway. > Ah, I misread the patch. Acked-by: Cong Wang <xiyou.wangcong@...il.com> Thanks! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists